Skip to content

Remove @shopify/react-testing#6920

Merged
gonzaloriestra merged 1 commit intomainfrom
remove-react-testing
Mar 13, 2026
Merged

Remove @shopify/react-testing#6920
gonzaloriestra merged 1 commit intomainfrom
remove-react-testing

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Mar 2, 2026 •
edited
Loading

WHY are these changes introduced?

There's a warning about @shopify/react-testing being deprecated

❯ pnpm install
Scope: all 14 workspace projects
packages/ui-extensions-dev-console       |  WARN  deprecated @shopify/react-testing@5.4.0
 WARN  8 deprecated subdependencies found: @shopify/useful-types@5.3.0, boolean@3.2.0, glob@10.5.0, glob@7.2.3, glob@8.1.0, inflight@1.0.6, node-domexception@1.0.0, whatwg-encoding@3.1.1
Packages: +16 -1
++++++++++++++++-
Progress: resolved 1980, reused 1830, downloaded 0, added 1, done
Done in 4.4s using pnpm v10.11.1

WHAT is this pull request doing?

Replaces that dependency with @testing-library/react

❯ pnpm install
Scope: all 14 workspace projects
 WARN  7 deprecated subdependencies found: boolean@3.2.0, glob@10.5.0, glob@7.2.3, glob@8.1.0, inflight@1.0.6, node-domexception@1.0.0, whatwg-encoding@3.1.1
Packages: +1
+
Progress: resolved 1977, reused 1827, downloaded 0, added 1, done
Done in 3.6s using pnpm v10.11.1

How to test your changes?

pnpm i

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

This was referenced Mar 2, 2026
Merged
Merged
@gonzaloriestra Graphite App
Copy link
Contributor Author

gonzaloriestra commented Mar 2, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gonzaloriestra gonzaloriestra mentioned this pull request Mar 2, 2026
Merged
5 tasks
@gonzaloriestra gonzaloriestra force-pushed the remove-react-testing branch 2 times, most recently from 0e36282 to 6867210 Compare March 2, 2026 12:03
@gonzaloriestra gonzaloriestra force-pushed the remove-react-i18n branch 2 times, most recently from 8ca6ef2 to ec4e89f Compare March 2, 2026 14:49
@gonzaloriestra gonzaloriestra force-pushed the remove-react-testing branch 2 times, most recently from 45379f0 to a2e6aed Compare March 3, 2026 10:49
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements 77.23% 14566/18860
🟡 Branches 70.87% 7227/10198
🟡 Functions 76.21% 3701/4856
🟡 Lines 78.72% 13769/17490

Test suite run success

3798 tests passing in 1460 suites.

Report generated by 🧪jest coverage report action from 50fc288

@gonzaloriestra
Copy link
Contributor Author

gonzaloriestra commented Mar 3, 2026

/snapit

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260303162806

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review March 4, 2026 11:43
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner March 4, 2026 11:43
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@binks-code-reviewer
Copy link

binks-code-reviewer bot commented Mar 4, 2026

🤖 Code Review · #projects-dev-ai for questions
React with 👍/👎 or reply — all feedback helps improve the agent.

✅ Complete - No issues

📋 History

✅ No issues

@isaacroldan
Copy link
Contributor

isaacroldan commented Mar 5, 2026

I think this should be reviewed by @Shopify/app-ui-extensibility too

@gonzaloriestra gonzaloriestra requested a review from a team March 5, 2026 13:36
Base automatically changed from remove-react-i18n to main March 13, 2026 10:32
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit dcd6203 Mar 13, 2026
47 of 68 checks passed
@gonzaloriestra gonzaloriestra deleted the remove-react-testing branch March 13, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacroldan isaacroldan isaacroldan approved these changes

@ryancbahan ryancbahan ryancbahan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gonzaloriestra @isaacroldan @ryancbahan